Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Fix f2py bugs when wrapping F90 subroutines. #18184

Merged
merged 8 commits into from
Jan 19, 2021
Merged

BUG: Fix f2py bugs when wrapping F90 subroutines. #18184

merged 8 commits into from
Jan 19, 2021

Conversation

pearu
Copy link
Contributor

@pearu pearu commented Jan 18, 2021 •
edited

This PR fixes the following bugs:

  • Fortran sources in fixed format were incorrectly detected as free format sources
  • f2py specific modules (with names containing __user__) must not be used in Fortran sources to be compiled
  • Subroutines/functions using assumed shape array inputs were incorrectly treated as F77 codes. Closes f2py: assumed shape array arguments break callback functionality #17797
  • Avoid splitting long comment lines

The PR supersedes #17800

@pearu pearu self-assigned this Jan 18, 2021
@pearu pearu marked this pull request as ready for review January 18, 2021 19:29
charris
charris reviewed Jan 18, 2021
View reviewed changes
numpy/f2py/crackfortran.py Outdated Show resolved Hide resolved
@charris
Copy link
Member

charris commented Jan 19, 2021

LGTM, just a couple of style suggestions.

@pearu pearu requested a review from charris January 19, 2021 09:03
eric-wieser
eric-wieser reviewed Jan 19, 2021
View reviewed changes
numpy/f2py/rules.py Outdated Show resolved Hide resolved
eric-wieser
eric-wieser reviewed Jan 19, 2021
View reviewed changes
numpy/f2py/rules.py Outdated Show resolved Hide resolved
@pearu pearu requested a review from charris January 19, 2021 19:36
@charris charris merged commit efaf210 into numpy:master Jan 19, 2021
@charris
Copy link
Member

charris commented Jan 19, 2021

Thanks Pearu.

@pearu pearu deleted the 17797 branch January 19, 2021 21:35
@krystophny krystophny mentioned this pull request Jan 20, 2021
Closed
@charris charris mentioned this pull request Feb 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattip mattip Awaiting requested review from mattip

@melissawm melissawm Awaiting requested review from melissawm

@eric-wieser eric-wieser Awaiting requested review from eric-wieser

@charris charris Awaiting requested review from charris

Assignees

@pearu pearu

Labels
00 - Bug 58 - Ready for review component: numpy.f2py
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

f2py: assumed shape array arguments break callback functionality
3 participants
@pearu @charris @eric-wieser