-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Clarify the type alias deprecation message #18230
Conversation
I tried to give some more details about integers in the release notes, and mention the precision version |
What was the reason to change the 1.20.0 release note? |
Thanks, have to try how to fix that reference. Will fix (maybe tomorrow morning). There was some discussion that this release note/deprecation is maybe a bit unclear. I hope this is a bit clearer (and "recipe style"), so the idea was to change it before the release. |
This tries to clarify the type alias deprecation message slightly to give more guidance on how to review the replacement (if desired).
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
This looks great, thanks @seberg! |
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Thanks Eric and Ross for figuring out how to correctly link the user guide... applied the changes, so should be good to go (assuming CI passes now). |
Thanks sebastian. |
This tries to clarify the type alias deprecation message slightly
to give more guidance on how to review the replacement (if desired).
The new messages are as follows: