Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Change license date 2020 -> 2021 #18346

Merged
merged 2 commits into from
Feb 6, 2021
Merged

DOC: Change license date 2020 -> 2021 #18346

merged 2 commits into from
Feb 6, 2021

Conversation

dmontesl
Copy link
Contributor

@dmontesl dmontesl commented Feb 6, 2021

A very small contribution to update the license date from 2020 to 2021 :)

@mattip
Copy link
Member

mattip commented Feb 6, 2021

There is one more in the copyright notice in doc/source/conf.py

Copy link
Member

@mattip mattip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charris charris added this to the 1.20.1 release milestone Feb 6, 2021
@seberg
Copy link
Member

seberg commented Feb 6, 2021

Interesting, the travis CI here also failed with the 16 byte alignment error I saw on my PR https://travis-ci.com/github/numpy/numpy/jobs/480993160#L4095

  numpy/core/src/multiarray/_multiarray_tests.c.src: In function ‘call_npy_cargl’:
4095  numpy/core/src/multiarray/_multiarray_tests.c.src:2000:9: note: the ABI of passing aggregates with 16-byte alignment has changed in GCC 5
4096           npy_@name@@suffix@(*(@itype@*)PyArray_DATA((PyArrayObject *)z_arr));
4097           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
4098

obviously unrelated, but does anyone know what this is?

@charris
Copy link
Member

charris commented Feb 6, 2021

That question was answered before, apparently it means that compiled code is not binary compatible between gcc 5 and gcc 4.

@seberg
Copy link
Member

seberg commented Feb 6, 2021

Oh, had not seen that. Makes sense, so we just don't worry about it and ignore these warnings when they crop up?

@charris
Copy link
Member

charris commented Feb 6, 2021

Found the explanation at #18220 (comment)

@seberg
Copy link
Member

seberg commented Feb 6, 2021

Thanks @Aerysv. And thanks Chuck, sorry for missing that.

gh-18349 should fix the circleci failure, no need to wait for this here though I think.

@seberg seberg merged commit 62b8296 into numpy:master Feb 6, 2021
charris pushed a commit to charris/numpy that referenced this pull request Feb 7, 2021
A very small contribution to update the license date from 2020 to 2021 :)
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Feb 7, 2021
@charris charris removed this from the 1.20.1 release milestone Feb 7, 2021
@dmontesl dmontesl deleted the patch-1 branch February 7, 2021 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants