Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Remove suspicious type casting #18485

Merged
merged 2 commits into from
Feb 25, 2021
Merged

BUG: Remove suspicious type casting #18485

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c69bef6
MAINT: Remove suspicious type casting
cgohlke Feb 24, 2021
0511a93
MAINT: cast Py_ssize_t to int
cgohlke Feb 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions numpy/core/src/multiarray/dtypemeta.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,12 +162,12 @@ void_discover_descr_from_pyobject(
}
if (PyBytes_Check(obj)) {
PyArray_Descr *descr = PyArray_DescrNewFromType(NPY_VOID);
Py_ssize_t itemsize = (int)PyBytes_Size(obj);
Py_ssize_t itemsize = PyBytes_Size(obj);
if (itemsize > NPY_MAX_INT) {
PyErr_SetString(PyExc_TypeError,
"byte-like to large to store inside array.");
}
descr->elsize = itemsize;
descr->elsize = (int)itemsize;
return descr;
}
PyErr_Format(PyExc_TypeError,
Expand Down