DOC: Emphasize distinctions between np.copy and ndarray.copy #18741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears you have included an extra "See Also" section, which sphinx didn't like. You will need to reorganize your changes for that to work. |
|
Thanks @melissawm. Fixed now. I don't understand the codecov error; it's pointing to lines I didn't touch... |
melissawm
reviewed
Apr 8, 2021
melissawm
reviewed
Apr 8, 2021
melissawm
requested changes
Apr 8, 2021
|
Thank you! |
|
The same codecov issue that is unrelated to anything I've changed, plus a new shippable error that also looks unrelated — maybe just a connectivity issue? |
melissawm
approved these changes
Apr 9, 2021
|
LGTM - @rossbar do you have anything to add? |
rossbar
approved these changes
Apr 9, 2021
There was a problem hiding this comment.
LGTM as well, thanks @moble & @melissawm
You're right, the coverage/shippable issues are unrelated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #15570 and #15685.
@rossbar clarified the documentation for
numpy.copy, butndarray.copywas left unchanged. This distinction recently bit me and one of my users again, which might have been avoided if the distinction were noted in both places.