MAINT: Remove dead codepath in generalized ufuncs #18864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seberg
commented
Apr 27, 2021
| @@ -2457,7 +2457,7 @@ PyUFunc_GeneralizedFunctionInternal(PyUFuncObject *ufunc, PyArrayObject **op, | |||
| /* Fill in any allocated outputs */ | |||
| { | |||
| PyArrayObject **operands = NpyIter_GetOperandArray(iter); | |||
| for (i = 0; i < nop; ++i) { | |||
| for (i = nin; i < nop; ++i) { | |||
There was a problem hiding this comment.
No point in iterating through all, op[i] cannot be NULL unless i >= nin.
There was a problem hiding this comment.
Frankly, this could be moved into the later loop, but for clarity, I wasn't sure that would actually be better...
|
Added a test for the (non-) possibility of an output that is broadcast. I am not 100% sure that it isn't possible to override the iterator flags in weird ways to allow a broadcast here, but I think I will put that into the realm of "doesn't really make sense" until proven otherwise. |
seberg
force-pushed
the
delete-nonsense-code-from-gufuncs
branch
from
a0ec427
to
7f6a1c2
Compare
If the iterator has size zero, then that means that the outer iteration has size. Since the outer iteration is unaffected by core dimensions, in that case the output always has size zero and the code does nothing but unnecessary checking the array sizes.
This ensures that it is correct to not initize the output array if the outer iteration has size 0. The broadcast result would always have size 0 in that case. If the iterator rejects such a broadcast it cannot happen.
seberg
force-pushed
the
delete-nonsense-code-from-gufuncs
branch
from
7f6a1c2
to
18ffb74
Compare
|
Thanks @seberg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the iterator has size zero, then that means that the outer
iteration has size. Since the outer iteration is unaffected by
core dimensions, in that case the output always has size zero
and the code does nothing but unnecessary checking the array sizes.
@rossbar this is a short PR you will like ;).