MAINT: Annotate missing attributes of np.number subclasses
#19344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BvB93
added
03 - Maintenance
09 - Backport-Candidate
BvB93
commented
Jun 25, 2021
| @@ -3313,6 +3327,21 @@ class floating(inexact[_NBit1]): | |||
| __args: Union[L[0], Tuple[()], Tuple[L[0]]] = ..., | |||
| ) -> float: ... | |||
| def tolist(self) -> float: ... | |||
| def is_integer(self: float64) -> bool: ... | |||
There was a problem hiding this comment.
A number of these methods are only available to np.float64 (xref #13375).
* `integer.numerator` & `denominator` * `integer.__round__` & `floating.__round__` * `floating.as_integer_ratio` * `float64.__getnewargs__` / `complex128.__getnewargs__` * `float64.is_integer`, `hex`, `fromhex`, `__trunc__` & `__getformat__` * `float64.__ceil__` & `float64.__floor__` (python >= 3.9 only)
BvB93
commented
Jun 25, 2021
Comment on lines
+3164
to
+3165
| @property | ||
| def denominator(self) -> L[1]: ... |
There was a problem hiding this comment.
I'd argue that denominator returning a builtins.int instance is somewhat concerning, especially for np.uint64.
|
Thanks Bas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #19339
A number of
np.numbersubclass attributes were previously absent from the stub files.This PR fixes aforementioned issue, adding annotations for the following properties and methods:
integer.numerator&denominatorinteger.__round__&floating.__round__floating.as_integer_ratiofloat64.__getnewargs__&complex128.__getnewargs__float64.is_integer,hex,fromhex,__trunc__&__getformat__float64.__ceil__&float64.__floor__(python >= 3.9 only)