Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: set Python version for 1.21.x to <3.11 #19497

Merged
merged 2 commits into from Jul 19, 2021

Conversation

rgommers
Copy link
Member

Note that SciPy has a more elaborate method here, using IS_RELEASE_BRANCH. Given that we're switching away from setup.py at some point and the ship kind of has sailed for 1.21.x already, I don't want to replicate that logic here.

Note that SciPy has a more elaborate method here, using
`IS_RELEASE_BRANCH`. Given that we're switching away from `setup.py` at
some point and the ship kind of has sailed for 1.21.x already,
I don't want to replicate that logic here.
@charris
Copy link
Member

charris commented Jul 16, 2021

I plan on adding Python 3.10 to a future 1.21 release.

@rgommers
Copy link
Member Author

I plan on adding Python 3.10 to a future 1.21 release.

This constraint is just meant to match whatever the release notes say. Which admittedly is a bit ambiguous right now:

The Python versions supported for this release are 3.7-3.9. Official
support for Python 3.10 will be added when it is released.

Did you mean for 1.21.0 upload wheels later, assuming they work without a patch? Or for 1.21.1 or up?

@charris
Copy link
Member

charris commented Jul 16, 2021

I'll release 1.21.1 this weekend. Python 3.10 is scheduled for 10/04 + 1-3 weeks to be available on azure, so probably will be supported in NumPy 1.21.4-5. Given the offset in Python and NumPy release cycles, I expect that sort of timing will persist. I like to keep the Python support up to date in a given release cycle because I suspect that distros like fedora will update both python and numpy in their spring releases.

@rgommers
Copy link
Member Author

I'll release 1.21.1 this weekend. Python 3.10 is scheduled for 10/04 + 1-3 weeks to be available on azure, so probably will be supported in NumPy 1.21.4-5.

Okay, then I think this is fine to merge. And it can be bumped to <3.11 for the first release in which we plan to support Python 3.10 - it's a minor thing in this case, but setting the upper limit matching the actual supported versions is a good habit.

@charris
Copy link
Member

charris commented Jul 18, 2021

Is 3.10.0b3 < 3.10 ?

I'm not sure. It should be, but it depends on the version comparison function used. Let's see what CI says.

@charris
Copy link
Member

charris commented Jul 18, 2021

Close/reopen to see if 3.10.0b3 tests run. That test was added after this PR was made.

@charris charris closed this Jul 18, 2021
@charris charris reopened this Jul 18, 2021
@charris
Copy link
Member

charris commented Jul 18, 2021

The 3.10.0b3 test runs. Thinking about it, how about using <= 3.10?

@rgommers
Copy link
Member Author

Thinking about it, how about using <= 3.10?

All right, since we have CI for 3.10 we may as well lie a little bit and let people build these releases from source.

Making it <3.11, since < is better than <= here I think (3.10.1 may not be <= 3.10)

@rgommers
Copy link
Member Author

Let's only add the trove classifier (Programming Language :: Python :: 3.10) for the version with wheels though.

@rgommers rgommers changed the title MAINT: set Python version correctly for 1.21.x (<3.10) MAINT: set Python version for 1.21.x to <3.11 Jul 18, 2021
@charris charris merged commit 42240ba into numpy:maintenance/1.21.x Jul 19, 2021
@charris
Copy link
Member

charris commented Jul 19, 2021

Thanks Ralf.

@rgommers rgommers deleted the max-pyversion branch July 19, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants