-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Update front page of documentation with Sphinx-Panels #19756
Conversation
Why remove the html templates?
|
The CI failures have nothing to do with your PR, it builds successfully locally. I think this has to do with a recently merged submodule #19478 |
Indeed, nice catch @melissawm . The unfortunate consequence of this is that the CircleCI build (which is used for doc preview) won't work. The easiest way to fix this would likely be to merge (or rebase, if you're comfortable, though this will require some manual conflict resolution) main into this branch. |
Thanks @melissawm and @rossbar! I've had problems previewing the SVGs used in the panels with LiverServe preview on Gitpod. PNGs in the panels work fine. I can't build locally since I use Windows. So SVG preview could be a LiveServe problem specifically. I think the sizing problems are due to the images automatically filling the whole panel. However, I can work around it by previewing in another image type (such as PNG) and using that to specify the dimensions. Then in my final commit, push as SVGs with the image dimensions. And change the folder used to doc/source/_static. For fixing the CircleCI build, could we do the merging or rebasing after the image changes? |
b94df38
to
0a168a7
Compare
Hi all, the a working version of the front page is now up! The various links work. However, the Getting Started page is incomplete right now, as a sphinx orphan page. Therefore this is more of a MVP as of now. However, there's been errors on CircleCI build specifically- I may need to rebase or update versions. Here's the visual for those who can't yet see the update due to the CircleCI error. Once the CircleCI works, it should be easier to see how the pages are connected and the user story flow. There are some other upcoming changes to make in a future PR, such as shrinking the size of the images (which has been a little fiddly since SVGs size differently than usual PNG). There's also been suggestions to change the how some content is organized, such as for F2Py in #18419. |
42c7c86
to
481a861
Compare
Hi all, this is ready to be merged. There were also some typos in my earlier screenshots that have been fixed. As discussed in the Community and Docs meetings, this can be merged before the late December version release. Builds on CI (best viewed in a non-Chrome browser, such as Firefox- images will not fully load on Chrome) so you can preview how it works. As of now, this visual re-design does not apply the whole site. It will replace the current 'NumPy v1.21 Manual' as the front page of the docs. Therefore only the front page of the docs has sphinx-panels implemented. In a future PR, there will be a new page, the 'Getting Started' that will include brief installation instructions and links to various guides, depending on user profile (Absolute Beginners, F2P, etc). This page will also have sphinx-panels. The panel 'User Guide' links to the current User Guide page. The original plan was to implement this visual change to multiple pages at once- however, I realized that process would take a long time without other people able to see or comment for feedback easily. So instead it will be implemented page by page, but a big picture overview is available in the interactive mock-up. These different pages will eventually visually unified, but the main function of the front page is retained. |
Getting started | ||
=============== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember correctly, the plan is to have the getting started button point to this page, and list the absolute beginners and quickstart under this, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup! The Getting Started page is currently an orphan page. It will be fleshed out in a future PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MarsBarLee ! I don't see any blockers at this point, any refinements can be done in a follow-up. LGTM!
Thanks @MarsBarLee . |
@MarsBarLee I hope you did not need anything from the merge of |
@MarsBarLee I note that graphics for "Getting Started" and "API Reference" are missing. Is that deliberate? |
Hi @charris, when building in CircleCI, there was a problem viewing the images in Chrome but no problem with other browser such as Firefox. I assumed this was a CircleCI specific issue. However, the problem may persist across Chrome browsers locally and in the release. It may be how Chrome displays different SVGs. I'll do some more cross-browser testing and make a PR to fix it CircleCI, so hopefully it's fixed elsewhere. Should I make a clone of the numpy:maintenance/1.22.x branchfor this? Or clone this branch from this PR? |
@MarsBarLee Make a PR branched from main, that is where everything in NumPy starts. After the fix is merged I will backport it. I put the original PR in 1.22.x so that any fixes that went into main could be easily backported. It would be nice if there was a fix before the release of 1.22.0 at the end of the month. |
@charris OK, thank you! Based on my current research it looks like a simple fix, so if it is, it can be done before the end of the month. |
Addresses #18419: Hard to navigate docs front page
I'm working with @rossbar to implement the following changes: