MAINT: Standardize guards in numpy/core/include #19826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charris
commented
Sep 4, 2021
| @@ -9,11 +9,12 @@ | |||
| #ifndef NPY_NO_DEPRECATED_API | |||
There was a problem hiding this comment.
Note that this is not a guard, it defines NPY_NO_DEPRECATED_API for use in Cython *.pyd files.
charris
changed the title
charris
changed the title
charris
force-pushed
the
cleanup-header-guards
branch
from
ff9e06a
to
0e1787c
Compare
This standardizes the header guards in numpy/core/include/numpy. The standard here is `<path>_<name>_H_` For instance, the file file: numpy/core/include/numpy/arrayobject.h guard: NUMPY_CORE_INCLUDE_NUMPY_ARRAYOBJECT_H_ Macro names can be up to 255 characters, so length is not a problem. This convention comes from the Google code style and keeps files with the same name but different locations from stepping on each other.
charris
force-pushed
the
cleanup-header-guards
branch
from
0e1787c
to
6dff0c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This standardizes the header guards in
numpy/core/include/numpy.The standard here is
<path>_<name>_H_For instance:file:
numpy/core/include/numpy/arrayobject.hguard:
NUMPY_CORE_INCLUDE_NUMPY_ARRAYOBJECT_H_Macro names can be up to 255 characters, so length is not a problem.
This convention comes from the Google code style and keeps files with
the same name but different locations from stepping on each other.