BUG: Fix nanpercentile ignoring the dtype of all-nan arrays
#19863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gnore the dtype for all-nan arrays
BvB93
commented
Sep 11, 2021
BvB93
changed the title
nanpercentile would ignore the dtype for all-nan arraysnanpercentile would ignore the dtype of all-nan arrays
Parametrize w.r.t. the axis, array dimensionality and dtype
charris
changed the title
nanpercentile would ignore the dtype of all-nan arraysnanpercentile ignoring the dtype of all-nan arrays
charris
reviewed
Sep 13, 2021
|
LGTM apart from the |
Co-Authored-By: Charles Harris <charlesr.harris@gmail.com>
|
Thanks Bas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #19854.
While expanding the
nan<x>test suite I noticed thatnanpercentile(andnanquantile) would ignore the initial arrays dtype whenever encountering all-nan arrays, always returning afloat64instead.Besides the bug fix, the test coverage of the
nan<x>functions has been improved for testings involving all-nan arrays,the relevant tests now being parametrized w.r.t. the array dtype, dimensionality and axis.