Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: mention changes to max_rows behaviour in np.loadtxt #21869

Merged
merged 1 commit into from Jun 28, 2022

Conversation

charris
Copy link
Member

@charris charris commented Jun 28, 2022

Backport of #21854.

I think this breaking change should be documented. Also, an example on how to replicate previous behaviour regarding comment lines might be appropriate. But not sure where to include:

import itertools
lines = itertools.islice(open("file"), start, end)
# where comment lines starts with '#'
filtered_lines = itertools.dropwhile(lambda x: x[:1] == '#', lines)
result = np.loadtxt(filtered_lines, ...)

Related issue: #21852

  • DOC: mention changes to max_rows behaviour

  • Clarify how line counting works in max_rows

…1854)

* DOC: mention changes to `max_rows` behaviour

* Clarify how line counting works in max_rows
@charris charris added 04 - Documentation 08 - Backport Used to tag backport PRs labels Jun 28, 2022
@charris charris added this to the 1.23.1 release milestone Jun 28, 2022
@charris charris changed the title DOC: mention changes to max_rows behaviour in np.loadtxt (#21854) DOC: mention changes to max_rows behaviour in np.loadtxt Jun 28, 2022
@charris charris merged commit c8eb140 into numpy:maintenance/1.23.x Jun 28, 2022
@charris charris deleted the backport-21854 branch June 28, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
04 - Documentation 08 - Backport Used to tag backport PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants