Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Update delimiter param description. #22372

Merged
merged 2 commits into from Oct 5, 2022

Conversation

rossbar
Copy link
Contributor

@rossbar rossbar commented Oct 3, 2022

Update the description for the delimiter parameter in loadtxt to note that only single-character strings are supported. In principle, this new info could be in a .. versionchanged:: 1.23 directive - any preference there @seberg ?

Closes #22311

Explicitly state that only single-character delimiters
are supported.
@seberg
Copy link
Member

seberg commented Oct 4, 2022

Yeah, I don't have a a real preference, but maybe it is good to be clear about the change. We also disallowed \n and \r (newline characters). (Now I remember that is because newlines are a no-op in the normal path, but in theory not if you consume iterables of lines rather than files.)

@seberg
Copy link
Member

seberg commented Oct 5, 2022

Thanks, Ross.

@seberg seberg merged commit 110d75d into numpy:main Oct 5, 2022
@rossbar rossbar added the 09 - Backport-Candidate PRs tagged should be backported label Oct 5, 2022
@rossbar
Copy link
Contributor Author

rossbar commented Oct 5, 2022

@charris I've added the backport candidate label for this one even though it's a docs PR. The change went into effect in 1.23 so the notification of the change in the docs should in principle be backported as well. It's not critically important though - apologies if this is an abuse of the backport candidate label!

@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

seems that from 1.23 the 'delimiter' option of loadtxt require single unicode character
3 participants