BUG: Fix refcounting errors found using pytest-leaks #22798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the clear errors I found based on pytest-leaks. One day it would be nice to fix up pytest-leaks to better support newer versions of pytest and cleaning up fixtures...
|
Thanks Sebastian. I put a 1.24.1 milestone on this as I plan to release 1.24.0 this weekend and don't want anymore new stuff in it. |
|
Can't we backport it without an RC? Half of it is in new functionality, so it doesn't matter much, but the filling leak may hit people in practice if they use |
|
We could, but the amount of new stuff keeps accumulating and eventually small risks become big risks. A 1.24.1 won't be too far in the future, probably early January. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the clear errors I found based on pytest-leaks. One day it would be nice to fix up pytest-leaks to better support newer versions of pytest and cleaning up fixtures...