BUG: Fix data stmt handling for complex values in f2py #23282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failure seems to be unrelated ( |
mattip
reviewed
Feb 27, 2023
HaoZeke
commented
Feb 27, 2023
mattip
added
the
triage review
|
I've decided to rework this, I'll extract the fix (and update it) with the original variables and open a new PR with the renamed variables. |
HaoZeke
force-pushed
the
fixDataStmtHandlingF2PY
branch
from
9b1ca14
to
a97f209
Compare
mattip
removed
the
triage review
|
@melissawm @HaoZeke any news here? |
I reworked it within the PR itself (with the force push) I think it should be good to go. |
|
Thanks Rohit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23276.
I also couldn't resist changing the variable names a bit for posterity.The crux of the fix is in e12392d
that the truncation is wrong for COMPLEX types, so we check for them and continueand uses regular expressions to capture the COMPLEX data correctly. The other commits are cleanups and tests.