DOC: Clean up errstate handling in our tests #23813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is plausible that this doesn't fix everything, but it fixes at least most.
rossbar
approved these changes
May 26, 2023
| >>> np.int16(32000) * np.int16(3) | ||
| 30464 | ||
| >>> np.seterr(over='raise') | ||
| {'divide': 'ignore', 'over': 'ignore', 'under': 'ignore', 'invalid': 'ignore'} |
There was a problem hiding this comment.
It's weird that this doesn't change the value in the returned dict, but indeed that is the behavior (the change is only reflected after calling geterr.
There was a problem hiding this comment.
It is a normal pattern for getters: you get back the old value so that you can reset it.
Honestly, we should maybe just remove this API in a follow-up and force users to use the errstate as only real api...
Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
charris
reviewed
May 26, 2023
| @@ -155,14 +154,18 @@ def geterr(): | |||
| -------- | |||
| >>> np.geterr() | |||
| {'divide': 'warn', 'over': 'warn', 'under': 'ignore', 'invalid': 'warn'} | |||
| >>> np.arange(3.) / np.arange(3.) | |||
| >>> np.arange(3.) / np.arange(3.) # doctest: +SHOW_WARNINGS | |||
There was a problem hiding this comment.
SHOW_WARNINGS seems to be invalid and breaks the refguide checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is plausible that this doesn't fix everything, but it fixes at least most.
This is split out from gh-23812 and fixes the doctests (and also some actual doc errors). Unfortunately, without gh-23812, I don't think this is even tested....