Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEST: change subprocess call to capture stderr too #23962

Merged
merged 1 commit into from
Jun 16, 2023
Merged

TEST: change subprocess call to capture stderr too #23962

merged 1 commit into from
Jun 16, 2023

Conversation

mattip
Copy link
Member

@mattip mattip commented Jun 16, 2023

Fixes #23954.
We could do a little better by lazily evaluating the function instead of doing it at import, but 🤷

@mattip mattip added the 09 - Backport-Candidate PRs tagged should be backported label Jun 16, 2023
@charris
Copy link
Member

charris commented Jun 16, 2023

Have you tested this on windows?

@mattip
Copy link
Member Author

mattip commented Jun 16, 2023

Have you tested this on windows?

yes

@charris charris merged commit 4d03867 into numpy:main Jun 16, 2023
60 checks passed
@charris
Copy link
Member

charris commented Jun 16, 2023

Thanks Matti.

@charris charris mentioned this pull request Jun 16, 2023
Merged
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charris charris charris approved these changes

Assignees
No one assigned
Labels
05 - Testing component: numpy.testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: message "'lscpu' is not recognized as an internal or external command, ..." printed
2 participants
@mattip @charris