Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix private procedures in f2py modules #23971

Merged
merged 5 commits into from
Jul 6, 2023
Merged

Conversation

HaoZeke
Copy link
Member

@HaoZeke HaoZeke commented Jun 17, 2023

Closes #23879. As far as f2py is concerned, private procedures are equivalent to skipfuncs.

One nit about this is that skipfuncs is a global variable, one of a few f2py uses, and would eventually need to be reworked (but that's a different discussion).

@charris charris added the 09 - Backport-Candidate PRs tagged should be backported label Jun 18, 2023
numpy/f2py/crackfortran.py Outdated Show resolved Hide resolved
@charris charris merged commit 3881c6f into numpy:main Jul 6, 2023
53 checks passed
@charris
Copy link
Member

charris commented Jul 6, 2023

Thanks @HaoZeke .

@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Jul 6, 2023
@charris charris modified the milestone: 1.25.2 release Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: f2py wraps private entities
2 participants