Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP: Expire set_numeric_ops and the corresponding C functions deprecation #23998

Merged
merged 2 commits into from Jun 20, 2023
Merged

DEP: Expire set_numeric_ops and the corresponding C functions deprecation #23998

merged 2 commits into from Jun 20, 2023

Conversation

seberg
Copy link
Member

@seberg seberg commented Jun 19, 2023

This simply expires the deprecations because I saw they were one cause of doctest failures in the other PR, but its good anyway.

@seberg
DEP: Expire set_numeric_ops and the corresponding C functions depre…
b6b5d97 
…cation

This simply expires the deprecations because I saw they were one cause
of doctest failures in the other PR, but its good anyway.
@seberg
MAINT: Also remove the new unused private _PyArray_GetNumericOps
179d2d5 
Unlike the set version, we don't use it internally.
mhvk
mhvk reviewed Jun 19, 2023
View reviewed changes
Copy link
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean-up is nice! But it looks like one should be able to get rid of number.c and number.h altogether! (moving some code to umathmodule)

numpy/core/src/multiarray/number.c Show resolved Hide resolved
mhvk
mhvk approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With that conversation resolved, I think this is all good to go!

@seberg seberg merged commit 9cba469 into numpy:main Jun 20, 2023
55 checks passed
@seberg seberg deleted the setnumericops branch June 20, 2023 17:10
F3eQnxN3RriK added a commit to F3eQnxN3RriK/numpy that referenced this pull request Jun 27, 2023
@F3eQnxN3RriK
DOC: Remove references to PyArray_SetNumericOps and ``PyArray_Get…
0816484 
…NumericOps`` in release note

``PyArray_SetNumericOps`` and ``PyArray_GetNumericOps`` are removed in
numpygh-23998.
@F3eQnxN3RriK F3eQnxN3RriK mentioned this pull request Jun 27, 2023
Merged
rossbar pushed a commit that referenced this pull request Jun 27, 2023
@F3eQnxN3RriK
DOC: Remove references to PyArray_SetNumericOps and ``PyArray_Get…
8d2c112 
…NumericOps`` in release note (#24058)

``PyArray_SetNumericOps`` and ``PyArray_GetNumericOps`` are removed in
gh-23998.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhvk mhvk mhvk approved these changes

Assignees
No one assigned
Labels
07 - Deprecation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@seberg @mhvk