Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Update python as glue doc. #24133

Merged
merged 2 commits into from
Jul 9, 2023
Merged

DOC: Update python as glue doc. #24133

merged 2 commits into from
Jul 9, 2023

Conversation

liang3zy22
Copy link
Contributor

As @mattip suggested, to close #7035 .

Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for me from adding this warning. At first I was inclined to see if there was appetite to remove it entirely, but then there are sections on f2py which likely are still relevant for NumPy. Longer term I think it'd be worthwhile to refactor the article to focus largely on f2py and refer readers to external resource(s) for general info on extensions.

I suggest to make the note more prominent so it stands out at the top of the doc. I'll let @mattip weigh in whether there are other ways this can be improved; LGTM!

doc/source/user/c-info.python-as-glue.rst Outdated Show resolved Hide resolved
Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
Copy link
Member

@mattip mattip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Once CI runs, a reviewer should look at the rendered doc to make sure it works as expected before merging.

@rossbar
Copy link
Contributor

rossbar commented Jul 9, 2023

Rendered docs look good, thanks @liang3zy22 and @mattip !

@rossbar rossbar merged commit 548aa74 into numpy:main Jul 9, 2023
57 checks passed
@liang3zy22 liang3zy22 deleted the gh7035 branch July 9, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Inaccurate caveat regarding ctypes
3 participants