-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Fix build issues on SPR and avx512_qsort float16 #25376
Conversation
adb9a59
to
0000e49
Compare
Enabling tests on SDE found a bug in avx512_qsort, which this patch fixes. |
It should also resolve #25382, Isn't? |
Yup, I found it when enabling the CI on Intel SDE TGL platform. It will be useful to run tests on TGL and SPR. |
intel_sde CI takes about 35 min to complete, let me know if you want me to split it. We could run TGL and SPR tests in separate CI jobs. |
Yes, it would be better also if the baseline of this test is set to |
|
Something went wrong with the Qemu tests. Will close and open to re-run them. |
Thank you Raghuveer. |
@r-devulap Is this bug present in 1.26.x? If so, could you make a bug fix PR for it? I don't want to try taking this whole PR back, the files have been renamed and reorganized. |
Fixes #25274, #25382
avx512_qsort<float16>
, which was detected when enabling the CI on TGL.