Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix build issues on SPR and avx512_qsort float16 #25376

Merged
merged 8 commits into from
Dec 15, 2023

Conversation

r-devulap
Copy link
Member

@r-devulap r-devulap commented Dec 12, 2023

Fixes #25274, #25382

  1. Marks explicit template specializations in x86-simd-sort as inline.
  2. Adds CI to run tests on TGL and SPR platforms with latest version of Intel SDE v9.27.
  3. Bug fix in avx512_qsort<float16>, which was detected when enabling the CI on TGL.

@r-devulap r-devulap force-pushed the spr-baseline branch 2 times, most recently from adb9a59 to 0000e49 Compare December 13, 2023 04:48
@r-devulap r-devulap changed the title MAINT: pull x86-simd-sort to latest BUG: Fix build issues on SPR and avx512_qsort float16 Dec 13, 2023
@r-devulap
Copy link
Member Author

Enabling tests on SDE found a bug in avx512_qsort, which this patch fixes.

@charris charris added the 09 - Backport-Candidate PRs tagged should be backported label Dec 13, 2023
@seiko2plus
Copy link
Member

It should also resolve #25382, Isn't?

@seiko2plus seiko2plus added the component: SIMD Issues in SIMD (fast instruction sets) code or machinery label Dec 13, 2023
@r-devulap
Copy link
Member Author

It should also resolve #25382, Isn't?

Yup, I found it when enabling the CI on Intel SDE TGL platform. It will be useful to run tests on TGL and SPR.

@r-devulap
Copy link
Member Author

intel_sde CI takes about 35 min to complete, let me know if you want me to split it. We could run TGL and SPR tests in separate CI jobs.

@seiko2plus
Copy link
Member

intel_sde CI takes about 35 min to complete, let me know if you want me to split it. We could run TGL and SPR tests in separate CI jobs.

Yes, it would be better also if the baseline of this test is set to avx512_spr so we can test static dispatching.

@r-devulap
Copy link
Member Author

r-devulap commented Dec 13, 2023

intel_sde is split into intel_sde_avx512 (cpu-baseline avx512f) and intel_sde_spr (cpu-baseline avx512_spr)

@r-devulap
Copy link
Member Author

Something went wrong with the Qemu tests. Will close and open to re-run them.

@r-devulap r-devulap closed this Dec 13, 2023
@r-devulap r-devulap reopened this Dec 13, 2023
@seiko2plus seiko2plus merged commit 08e6252 into numpy:main Dec 15, 2023
63 checks passed
@seiko2plus
Copy link
Member

Thank you Raghuveer.

@charris
Copy link
Member

charris commented Dec 22, 2023

Bug fix in avx512_qsort, which was detected when enabling the CI on TGL.

@r-devulap Is this bug present in 1.26.x? If so, could you make a bug fix PR for it? I don't want to try taking this whole PR back, the files have been renamed and reorganized.

@r-devulap
Copy link
Member Author

@charris see #25475.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
03 - Maintenance component: SIMD Issues in SIMD (fast instruction sets) code or machinery
Projects
None yet
3 participants