Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: fix warning about visibility tag on clang #25657

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

ngoldbaum
Copy link
Member

This fixes a warning reported by clang:

In file included from ../numpy/fft/_pocketfft_umath.c:23:
../numpy/fft/pocketfft/pocketfft.h:19:1: warning: attribute 'visibility' is ignored, place it after "struct" to apply attribute to type declaration [-Wignored-attributes]
NPY_VISIBILITY_HIDDEN struct cfft_plan_i;
^

I don't have gcc locally so let's see if other compilers complain

@seberg
Copy link
Member

seberg commented Jan 22, 2024

Ooops, I don't think the struct needs it at all? It is just a definition for the later typedef after all, not an actual symbol.

Copy link
Member

@seberg seberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just adding suggestions, if you want just adopt that. In any case, please feel free to merge once you are happy.

numpy/fft/pocketfft/pocketfft.h Outdated Show resolved Hide resolved
numpy/fft/pocketfft/pocketfft.h Outdated Show resolved Hide resolved
Co-authored-by: Sebastian Berg <sebastian@sipsolutions.net>
@ngoldbaum ngoldbaum merged commit a9c1096 into numpy:main Jan 22, 2024
61 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants