Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Adjust rest of string ufuncs to static_data approach #25847

Merged
merged 1 commit into from
Feb 20, 2024
Merged

MAINT: Adjust rest of string ufuncs to static_data approach #25847

merged 1 commit into from
Feb 20, 2024

Conversation

lysnikolaou
Copy link
Contributor

No description provided.

@charris
Copy link
Member

charris commented Feb 18, 2024

@mattip Any idea what is going on with the BLAS tests (Linux) / Test Linux (nightly OpenBLAS) failures?

@ngoldbaum
Copy link
Member

@charris see #25849.

@mhvk any chance you have some time this week to look over this refactor?

ngoldbaum
ngoldbaum approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@ngoldbaum ngoldbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a straightforward refactor and looks correct to me.

@ngoldbaum ngoldbaum merged commit 6aab039 into numpy:main Feb 20, 2024
62 of 64 checks passed
mhvk
mhvk reviewed Feb 20, 2024
View reviewed changes
Copy link
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this, but agreed this is a straightforward refactor - nice to see it used here too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhvk mhvk mhvk left review comments

@ngoldbaum ngoldbaum ngoldbaum approved these changes

Assignees
No one assigned
Labels
03 - Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lysnikolaou @charris @ngoldbaum @mhvk