MAINT: add missing noexcept clauses #26129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After cython/cython#6087 it's much easier to figure out the missing noexcept clauses. Indeed, cython up to 3.0.9 has a warning that gives lots of false positives, but with the PR above (already merged in cython master and backported to 3.0.x) all the warnings are indeed cases of missing noexcept To test use this file `test_cimport.pyx`: ``` # cython: language_level=3 cimport numpy cimport numpy.random cimport numpy.random._bounded_integers cimport numpy.random._common cimport numpy.random.bit_generator cimport numpy.random.c_distributions ``` and build with `cython -X legacy_implicit_noexcept=True test_cimport.pyx` This commit applies cleanly to the 1.26.x branch and is meant to backport. The next commit fixes the remaining instances.
This commit fixes the remaining instances. See description in previous commit.
|
Seems to make sense. I don't think we are backporting to 1.26 at this point. Edit: We should backport this to 2.0.0 |
|
I am planning on one more 1.26 release around the time of 2.0.0 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After cython/cython#6087 it's much easier to figure out the missing noexcept clauses. Indeed, cython up to 3.0.9 has a warning that gives lots of false positives, but with the PR above (already merged in cython master and backported to 3.0.x) all the warnings are indeed cases of missing noexcept
To test use this file
test_cimport.pyx:and build with
cython -X legacy_implicit_noexcept=True test_cimport.pyx(using patched cython, otherwise there will still be false positive warnings).The first commit applies cleanly to the 1.26.x branch and is meant to backport.
The second commit fixes the remaining instances.