Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: add missing noexcept clauses #26129

Merged
merged 2 commits into from
Mar 25, 2024
Merged

MAINT: add missing noexcept clauses #26129

merged 2 commits into from
Mar 25, 2024

Commits on Mar 25, 2024

  1. MAINT: add missing noexcept clauses (1/2) 

    After cython/cython#6087 it's much easier to
figure out the missing noexcept clauses. Indeed, cython up to 3.0.9 has
a warning that gives lots of false positives, but with the PR above
(already merged in cython master and backported to 3.0.x) all the
warnings are indeed cases of missing noexcept

To test use this file `test_cimport.pyx`:
```
# cython: language_level=3
cimport numpy
cimport numpy.random
cimport numpy.random._bounded_integers
cimport numpy.random._common
cimport numpy.random.bit_generator
cimport numpy.random.c_distributions
```
and build with `cython -X legacy_implicit_noexcept=True test_cimport.pyx`

This commit applies cleanly to the 1.26.x branch and is meant to
backport. The next commit fixes the remaining instances.
    @tornaria
    tornaria committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    9b27220 View commit details
    Browse the repository at this point in the history

  2. MAINT: add missing noexcept clauses (2/2) 

    This commit fixes the remaining instances.

See description in previous commit.
    @tornaria
    tornaria committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    4045a60 View commit details
    Browse the repository at this point in the history