-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: attempt to fix intel SDE SIMD CI #26447
Conversation
Looks like switching the runner images worked. According to actions/runner-images#9679 we can get back g++-13 on the old image by doing:
@r-devulap can you take a look and let me know if switching to Ubuntu-24.04 broke anything in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Minor comment, feel free to ignore. Thanks for fixing it :)
sudo apt update | ||
sudo apt install -y g++-13 | ||
sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-13 1 | ||
sudo update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-13 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps explicitly set CXX=g++-13
and CC=gcc-13
in the Build
section below for my sanity? :)
It looks like the SDE tests passed so let's bring this in to unbreak CI. |
Backports of numpy#26443, numpy#26445, numpy#26447 commit 406dce8649f2162eec5664e1007654ec660510c1 Author: Nathan Goldbaum <nathan.goldbaum@gmail.com> Date: Thu May 16 09:05:34 2024 -0600 MNT: set CC and CXX for intel SDE tests commit 5b0243794d37c5d15e02b47c7cf50c9fe027cc2f Author: Nathan Goldbaum <nathan.goldbaum@gmail.com> Date: Wed May 15 17:12:26 2024 -0600 MNT: remove unncessary dependency installation steps commit 6db88e7ff7302e1b381029f7c13ff9ebafaa19e3 Author: Nathan Goldbaum <nathan.goldbaum@gmail.com> Date: Wed May 15 16:58:21 2024 -0600 TST: attempt to fix intel SDE SIMD CI commit 2b09beb488fcfd34dfdb5f91b4c0f8e9ecb1323f Author: Nathan Goldbaum <nathan.goldbaum@gmail.com> Date: Wed May 15 12:28:13 2024 -0600 TST: fix xfailed tests on pypy 7.3.16 commit ee9ebc1c465189163d828c4006239d0bf3d49db6 Author: Nathan Goldbaum <nathan.goldbaum@gmail.com> Date: Wed May 15 10:53:42 2024 -0600 TST: temporarily pin spin to work around issue in 0.9 release
Backports of numpy#26443, numpy#26445, numpy#26447 commit 406dce8649f2162eec5664e1007654ec660510c1 Author: Nathan Goldbaum <nathan.goldbaum@gmail.com> Date: Thu May 16 09:05:34 2024 -0600 MNT: set CC and CXX for intel SDE tests commit 5b0243794d37c5d15e02b47c7cf50c9fe027cc2f Author: Nathan Goldbaum <nathan.goldbaum@gmail.com> Date: Wed May 15 17:12:26 2024 -0600 MNT: remove unncessary dependency installation steps commit 6db88e7ff7302e1b381029f7c13ff9ebafaa19e3 Author: Nathan Goldbaum <nathan.goldbaum@gmail.com> Date: Wed May 15 16:58:21 2024 -0600 TST: attempt to fix intel SDE SIMD CI commit 2b09beb488fcfd34dfdb5f91b4c0f8e9ecb1323f Author: Nathan Goldbaum <nathan.goldbaum@gmail.com> Date: Wed May 15 12:28:13 2024 -0600 TST: fix xfailed tests on pypy 7.3.16 commit ee9ebc1c465189163d828c4006239d0bf3d49db6 Author: Nathan Goldbaum <nathan.goldbaum@gmail.com> Date: Wed May 15 10:53:42 2024 -0600 TST: temporarily pin spin to work around issue in 0.9 release MAINT: Copy linux_simd.yml from main.
It looks like the gcc-13 setup on the ubuntu 22.04 runners was removed today: actions/runner-images#9854.
Let's see if switching to 24.04 lets us install a sufficiently new gcc without breaking anything else.