TST: temporarily pin spin to work around issue in 0.9 release #26443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, the PyPy problems persist. |
|
The pypy problems look related to the strict setting, i.e., the tests fail because they xpass. @ngoldbaum That seems like an odd choice. |
|
I tend to mark tests as xfailed with strict=True, with the expectation that CI will break in the future once the bug is fixed. That seems better to me than having lots of tests incorrectly marked as xfail long after the bugs are fixed. |
charris
added a commit
to charris/numpy
that referenced
this pull request
May 16, 2024
Backports of numpy#26443, numpy#26445, numpy#26447 commit 406dce8649f2162eec5664e1007654ec660510c1 Author: Nathan Goldbaum <nathan.goldbaum@gmail.com> Date: Thu May 16 09:05:34 2024 -0600 MNT: set CC and CXX for intel SDE tests commit 5b0243794d37c5d15e02b47c7cf50c9fe027cc2f Author: Nathan Goldbaum <nathan.goldbaum@gmail.com> Date: Wed May 15 17:12:26 2024 -0600 MNT: remove unncessary dependency installation steps commit 6db88e7ff7302e1b381029f7c13ff9ebafaa19e3 Author: Nathan Goldbaum <nathan.goldbaum@gmail.com> Date: Wed May 15 16:58:21 2024 -0600 TST: attempt to fix intel SDE SIMD CI commit 2b09beb488fcfd34dfdb5f91b4c0f8e9ecb1323f Author: Nathan Goldbaum <nathan.goldbaum@gmail.com> Date: Wed May 15 12:28:13 2024 -0600 TST: fix xfailed tests on pypy 7.3.16 commit ee9ebc1c465189163d828c4006239d0bf3d49db6 Author: Nathan Goldbaum <nathan.goldbaum@gmail.com> Date: Wed May 15 10:53:42 2024 -0600 TST: temporarily pin spin to work around issue in 0.9 release
charris
added a commit
to charris/numpy
that referenced
this pull request
May 16, 2024
Backports of numpy#26443, numpy#26445, numpy#26447 commit 406dce8649f2162eec5664e1007654ec660510c1 Author: Nathan Goldbaum <nathan.goldbaum@gmail.com> Date: Thu May 16 09:05:34 2024 -0600 MNT: set CC and CXX for intel SDE tests commit 5b0243794d37c5d15e02b47c7cf50c9fe027cc2f Author: Nathan Goldbaum <nathan.goldbaum@gmail.com> Date: Wed May 15 17:12:26 2024 -0600 MNT: remove unncessary dependency installation steps commit 6db88e7ff7302e1b381029f7c13ff9ebafaa19e3 Author: Nathan Goldbaum <nathan.goldbaum@gmail.com> Date: Wed May 15 16:58:21 2024 -0600 TST: attempt to fix intel SDE SIMD CI commit 2b09beb488fcfd34dfdb5f91b4c0f8e9ecb1323f Author: Nathan Goldbaum <nathan.goldbaum@gmail.com> Date: Wed May 15 12:28:13 2024 -0600 TST: fix xfailed tests on pypy 7.3.16 commit ee9ebc1c465189163d828c4006239d0bf3d49db6 Author: Nathan Goldbaum <nathan.goldbaum@gmail.com> Date: Wed May 15 10:53:42 2024 -0600 TST: temporarily pin spin to work around issue in 0.9 release MAINT: Copy linux_simd.yml from main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the build failures seen on mac conda CI: https://github.com/numpy/numpy/actions/runs/9099364436/job/25011771454?pr=26441
See scientific-python/spin#193.
A fix should be out in a few days but it will take a while to propagate to conda-forge, so let's unbreak the broken CI job for now. @stefanv I'd appreciate it if you could unpin this when a release is out with a fix.