Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing Issue 10003 : Adding datetime64 example for 'Now' to get the current time #26477

Closed
wants to merge 3 commits into from

Conversation

Shreyjaradi
Copy link

No description provided.

@mattip
Copy link
Member

mattip commented May 19, 2024

This fails doctests. You should add a +SKIP directive, like here

>>> rng.random() #doctest: +SKIP

File "/tmp/tmpeo8sv853/doc/source/reference/arrays.datetime.rst", line 93, in doc/source/reference/arrays.datetime.rst
Failed example:
    np.datetime64('now', 'ms')
Expected:
    numpy.datetime64('2024-05-18T18:02:42.000')
Got:
    np.datetime64('2024-05-18T18:58:30.000')

@Shreyjaradi
Copy link
Author

Shreyjaradi commented May 20, 2024

@mattip Thank you so much, I have made the changes, this is my first open source contribution at PyCon US 2024 Pittsburgh.

@Shreyjaradi
Copy link
Author

@mattip , Can we close this ?

@rossbar
Copy link
Contributor

rossbar commented May 21, 2024

Just FYI, it's always a good idea to submit features on a branch other than your main branch - one reason why is that maintainers often push minor suggestions to the PR to make things quicker; however this is not possible for PRs that originate from the main branch on your fork. Just a little nugget for next time!

I will go ahead and close as requested!

@rossbar rossbar closed this May 21, 2024
@Shreyjaradi
Copy link
Author

Shreyjaradi commented May 21, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants