FIX: Fixed np.load time when file is large & compressed. #26509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajat315315
force-pushed
the
numpy.load-time-slow
branch
from
fe04a0a
to
7f7f6bd
Compare
seberg
reviewed
May 24, 2024
numpy/lib/_npyio_impl.py
Outdated
| assert info.compress_type == 0 | ||
| self.zip.fp.seek( | ||
| info.header_offset + len(info.FileHeader()) + 20 | ||
| ) |
There was a problem hiding this comment.
A small nitpicks is that NameToInfo seems undocumented, so I think using .getinfo() is maybe nicer (unfortunately, so is FileHeader()).
One worry is that without duplicating fp first this isn't thread-safe or is NpzFile so fundamentally not thread-safe that we don't have to worry about it?
I am have wondering if we could clean up the read_array to use fp.readinto(res_array) to safe unnecessary copies. Unfortunately, zipfile doesn't implement a specialized readinto so that only saves 1 of the two copies. (which still may be nice on its own.)
There was a problem hiding this comment.
Maybe OP can answer about thread-safety as he seemed to introduce the code..
rajat315315
force-pushed
the
numpy.load-time-slow
branch
from
2da086c
to
41f18ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #26498
Instead of passing an object of
zipfile.ZipExtFiletoformat.read_array(), I am now passing_io.BufferedReaderwhose read() is faster.