Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ticket #2178: "own" (to close) file handles in load() only if they were not opened before #328

Merged
merged 7 commits into from
Jul 6, 2012
Merged

fix ticket #2178: "own" (to close) file handles in load() only if they were not opened before #328

merged 7 commits into from
Jul 6, 2012

Commits on Jul 2, 2012

  1. BUG: do not "own" the FID for GzipFile and file if provided to load a… 

    …lready opened (ticket numpy#2178)

Also made all assignments of own_file go in pair with assignments to fid to make things clearer
    @yarikoptic
    yarikoptic committed Jul 2, 2012
    Configuration menu
    Copy the full SHA
    4df2444 View commit details
    Browse the repository at this point in the history

  2. ENH: unittest for preceeding commit fixing numpy#2178

    @yarikoptic
    yarikoptic committed Jul 2, 2012
    Configuration menu
    Copy the full SHA
    0e3a3d9 View commit details
    Browse the repository at this point in the history

  3. BF: PY3 and PY2 < 2.7 compatibility fixes for prev 2 commits

    @yarikoptic
    yarikoptic committed Jul 2, 2012
    Configuration menu
    Copy the full SHA
    4219824 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2012

  1. ENH: Since file handle could not be reopened (during load()) -- no ne… 

    …ed for "isclosed" logic
    @yarikoptic
    yarikoptic committed Jul 5, 2012
    Configuration menu
    Copy the full SHA
    153f764 View commit details
    Browse the repository at this point in the history

  2. ENH: added a rudimentary test for having numpy#1517 (too many open fi… 

    …les) fixed
    @yarikoptic
    yarikoptic committed Jul 5, 2012
    Configuration menu
    Copy the full SHA
    81a03cf View commit details
    Browse the repository at this point in the history

  3. BF: removed too much -- own_fid should be False while working with .npz

    @yarikoptic
    yarikoptic committed Jul 5, 2012
    Configuration menu
    Copy the full SHA
    c35c83c View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2012

  1. BF(PY3): open file handles in tests in binary mode 

    otherwise zipfile of python3 gets confused to receive bytes for the header
whenever handle is opened for a text (unicode) file
    @yarikoptic
    yarikoptic committed Jul 6, 2012
    Configuration menu
    Copy the full SHA
    613589e View commit details
    Browse the repository at this point in the history