Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: error in broadcast_arrays with as_strided array #6556

Merged
merged 1 commit into from
Oct 24, 2015

Conversation

shoyer
Copy link
Member

@shoyer shoyer commented Oct 24, 2015

Fixes #6491

nb. this is an awkward solution -- I don't really understand why it works. I suspect it is working around some quirks of the logic for checking if arrays can be made writeable, which is surprisingly convoluted. Note, for example, that base on an array from as_strided is a stride_tricks.DummyArray.

@charris charris added this to the 1.10.2 release milestone Oct 24, 2015
@charris
Copy link
Member

charris commented Oct 24, 2015

I don't really know what is going on here, but the fix looks reasonable in a complicated sort of way ;)

charris added a commit that referenced this pull request Oct 24, 2015
BUG: error in broadcast_arrays with as_strided array
@charris charris merged commit cec39ef into numpy:master Oct 24, 2015
@charris
Copy link
Member

charris commented Oct 24, 2015

Thanks Stephan.

@rgommers
Copy link
Member

Thanks! Fixed the one failure that blocked us from enabling testing against 1.10.1 on TravisCI with Scipy.

@shoyer shoyer deleted the fix-broadcast-arrays branch October 24, 2015 22:46
@njsmith
Copy link
Member

njsmith commented Oct 25, 2015

Ideally the code could be written in such a way that the writeable flag is
set correctly from the beginning instead of needing to be mutated, but 30
seconds looking at the code certainly does not make it obvious how to do
this :-).

On Sat, Oct 24, 2015 at 2:55 PM, Ralf Gommers notifications@github.com
wrote:

Thanks! Fixed the one failure that blocked us from enabling testing
against 1.10.1 on TravisCI with Scipy.


Reply to this email directly or view it on GitHub
#6556 (comment).

Nathaniel J. Smith -- http://vorpus.org

@charris
Copy link
Member

charris commented Oct 25, 2015

Yep. Feel free to refactor for 1.11... :-)

@charris charris removed this from the 1.10.2 release milestone Oct 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants