Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 7088, BUG: Have norm cast non-floating point arrays to 64-bit float arrays #7098

Merged

Conversation

jakirkham
Copy link
Contributor

Related: #7088
Fixes: #5626

Backported from master to 1.11.x.

Simply ensures that non-floating type arrays passed to norm get cast to some form of float.

@jakirkham
Copy link
Contributor Author

@charris, here is the backport of this PR ( #7088 ).

@charris charris changed the title BUG: Have norm cast non-floating point arrays to 64-bit float arrays (Backport 1.11.x) Backport 7088, BUG: Have norm cast non-floating point arrays to 64-bit float arrays Jan 23, 2016
@charris charris added this to the 1.11.0 release milestone Jan 23, 2016
@charris
Copy link
Member

charris commented Jan 23, 2016

Hmm, I just made one also but haven't pushed it. Could you fix up the commit messages as suggested in the previous #7088?

@jakirkham
Copy link
Contributor Author

Is there a good way to tell vi to color code lines that go over some length? I feel like I will always miss this if it doesn't point it out to me.

@charris
Copy link
Member

charris commented Jan 23, 2016

There probably is. I just do :set tw=72 and use gq on the selected text. Setting tw should also cause a wrap at the selected line length. I would be good to set that when git calls up the text editor, maybe there is a way to specify that.

@jakirkham
Copy link
Contributor Author

Ok, thanks for the pointer. I think these are correct.

@charris
Copy link
Member

charris commented Jan 23, 2016

http://stackoverflow.com/questions/11023194/git-vim-automatically-wrap-long-commit-messages Looks like there is also a git.commit plugin.

@jakirkham
Copy link
Contributor Author

Was just looking at that. Though my system vi is ancient so I don't know if they will play nice.

@jakirkham
Copy link
Contributor Author

Managed to fixup vi. This is pretty slick. It just autowraps when writing a commit message. Also, it encourages you to keep a newline between your summary message and the body.

@charris
Copy link
Member

charris commented Jan 23, 2016

You are having better luck than me. There must be a conflict somewhere in my vim configuration.

@jakirkham
Copy link
Contributor Author

Looks like everything checks out.

charris added a commit that referenced this pull request Jan 23, 2016
Backport 7088, BUG: Have `norm` cast non-floating point arrays to 64-bit float arrays
@charris charris merged commit e02c46f into numpy:maintenance/1.11.x Jan 23, 2016
@charris
Copy link
Member

charris commented Jan 23, 2016

OK, thanks.

@jakirkham
Copy link
Contributor Author

Sure. Did you ever git vim figured out?

@jakirkham jakirkham deleted the cast_float_linalg_bp_1_11_x branch January 23, 2016 05:25
@mgeier
Copy link
Contributor

mgeier commented Apr 27, 2016

This introduced a regression, see #7575.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants