ENH: savez: temporary file alongside with target file and improve exception message upon IOError #7133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not sure why appveyor tests didn't run, but otherwise -- ready for review ;) |
|
bzz bzz -- noone is interested to review/feedback? |
|
LGTM -- Thanks Yaroslav! |
njsmith
added a commit
that referenced
this pull request
Feb 9, 2016
savez: temporary file alongside with target file and improve exception message upon IOError
This was referenced Feb 9, 2016
Closed
Closed
charris
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fully resolve #5336 -- for output of large files temporary files would be created alongside with target ones, so it would be logical to expect sufficient amount of storage available (unlike under TEMPDIR). Also error message would carry the filename of the tempfile in question which could better direct user toward possible problems on the target partition.
I haven't tested it locally, neither looked into where to provide such a test -- let's see first if travis says Ok. If testing desired -- point to location where to provide one. Cheers!