BUG: mode kwargs passed as unicode to np.pad raises an exception #7152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isinstance(mode, str) is False in python2.7 when mode is of unicode type, and mode is then mistakenly assumed to be a callable. See numpy#7112
|
LGTM, but I'll wait for appveyor (sigh) |
|
thanks for the review Nathaniel. Looks like appveyor is finally done :) |
charris
added a commit
that referenced
this pull request
Jan 31, 2016
BUG: mode kwargs passed as unicode to np.pad raises an exception
|
Thanks @bertrand-l . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isinstance(mode, str)is False in python2.7 whenmodeis of unicodetype, and
modeis then mistakenly assumed to be a callable whichraises an exception. This should close #7112