TST: Pin virtualenv used on Travis CI. #7197
Conversation
|
@charris, I think this might fix it. Looks like it works for me at least. |
|
Not sure why travis isn't running, maybe the script change. |
|
Yeah, I thought maybe the GitHub UI was being funky. Guess not if you are seeing it. Especially as there was no build on Travis. |
jakirkham
force-pushed
the
pin_virtualenv
branch
from
9b90935
to
938d45b
Compare
|
Now it's going. Went ahead and added the quotes. Didn't seem to matter for Travis on my fork, but if it makes it happy. |
|
Travis now passes. Probably not worth waiting for AppVeyor on a Travis only fix or do we need this change on AppVeyor too? |
| @@ -77,6 +77,7 @@ before_install: | |||
| - pushd builds | |||
| # Build into own virtualenv | |||
| # We therefore control our own environment, avoid travis' numpy | |||
| - pip install -U 'virtualenv==14.0.4' | |||
There was a problem hiding this comment.
Should probably add a comment as to why the version is pinned. We will probably want to revisit this when the next venv shows up ;)
There was a problem hiding this comment.
Sure, not really sure I understand the problem. Something about f2py and the path. Maybe you could tell me what you would like to see here.
There was a problem hiding this comment.
Just mention that test_f2py was failing with virtualenv==14.0.5.
|
Agree that we don't need to wait on appveyor, In fact, you can skip it with |
|
Oh nifty, I was wondering if there was a way to do explicit CI skips. |
jakirkham
force-pushed
the
pin_virtualenv
branch
from
938d45b
to
4db3e19
Compare
| @@ -77,6 +77,10 @@ before_install: | |||
| - pushd builds | |||
| # Build into own virtualenv | |||
| # We therefore control our own environment, avoid travis' numpy | |||
| # | |||
| # Some change in virtualenv 14.0.5 caused `test_f2py` to fail. So, we have | |||
| # pinned `virtualenv` to the last known working version to avoid this failure. | |||
There was a problem hiding this comment.
How does this comment look to you?
There was a problem hiding this comment.
Would be good to figure out why it fails, but I don't have time today and
it doesn't sound like anyone else does, so oh well a temporary hack does
put off the problem :-)
.
(Adding an 'ls path/to/venv/bin' to a failing build would be informative
about what's going on...)
.
NB for clarity: "virtualenv" and "venv" are actually two different things
(venv's are virtualenv-like environments that are provided as a built-in
feature of recent py3 releases).
On Fri, Feb 5, 2016 at 12:42 PM, jakirkham notifications@github.com wrote:
In .travis.yml
#7197 (comment):@@ -77,6 +77,10 @@ before_install:
- pushd builds
Build into own virtualenv
We therefore control our own environment, avoid travis' numpy
Some change in virtualenv 14.0.5 caused
test_f2pyto fail. So, we havepinned
virtualenvto the last known working version to avoid this failure.How does this comment look to you?
—
Reply to this email directly or view it on GitHub
https://github.com/numpy/numpy/pull/7197/files#r52070007.
Nathaniel J. Smith -- https://vorpus.org http://vorpus.org
There was a problem hiding this comment.
Haha, yeah, would be nice. Figured I'd just end the stream of Travis failed emails instead.
Honestly, it is cases like this where I start preferring a different sort of CI all together like CircleCI where one can inspect the VM or Wercker where one can not only inspect a failed build, but can run the CI locally. The hack stuff into the CI script and wait a few minutes before more hacking just doesn't cut it for me.
Yep, I did discover that recently. Still this somehow fixes it. Kind of a mystery why atm.
There was a problem hiding this comment.
Yeah, the problem is that AFAICT Travis is more generous than everyone else with respect to how much CPU time they offer to open source projects (e.g. CircleCI gives you 3 parallel workers, Drone.io gives you 1, Travis gives you 6. OTOH I haven't checked how fast Travis's workers are compared to the others...).
I'm 95% sure I saw somewhere where you can download the Travis container images to run locally, but now I can't seem to find it :-(
There was a problem hiding this comment.
Yeah, I thought I saw some sort of Travis CLI tool at some point too, but the docs on this seem to disappear, as well.
There was a problem hiding this comment.
I suppose there is this ( https://github.com/travis-ci/travis-build ) and this ( https://github.com/travis-ci/worker ), but it feels like a bit much to get started with.
Alternatively, there is a docker image ( https://github.com/SonarSource/local-travis ) that can be pulled from Docker Hub that might be more friendly, but this is unofficial.
TST: Pin virtualenv used on Travis CI.
|
Thanks @jakirkham . Hopefully this will hold it for a while... |
|
Of course. Hope so. |
Not sure if this will help at all, but this is an attempt at trying to workaround the test failures on
master.