TST: Add test for #6469 #7341
Merged
TST: Add test for #6469 #7341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1279,6 +1279,13 @@ def test_empty(self): | |||
| a, b = histogram([], bins=([0, 1])) | |||
| assert_array_equal(a, np.array([0])) | |||
| assert_array_equal(b, np.array([0, 1])) | |||
|
|
|||
| def test_error_binnum_type (self): | |||
| #test should check the right error message is returned if a float is passed on a binnumber | |||
|
Looks like you merged master into your branch (bad idea) and got an extra commit. I think you can fix it by |
|
Where did you make this fix? I don't see a branch in your repo. |
|
Sorry for the mess! I did the rebase as you suggested, hope this is better. |
|
Apparently there is still a problem, but I could not find out why the test failed. Did I do something else wrong? I apologize again for the mess... |
|
It looks as though Travis CI failed to get a working Python 3.5 running for one of the tests. It's not really the code change that failed but rather Travis CI. (Or I'm misinterpretting the log output) |
|
Thanks @inesw . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a test for issue #6469:
The issue itself has been fixed in 34b582a .
Checks that TypeError is raised if in function histogram argument bins is a float.
This pull request is part of a BCCN Berlin student project featuring @WHops @rahul-nt @MaxKirstein @inesw