-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Add test for #6469 #7341
TST: Add test for #6469 #7341
Conversation
@@ -1279,6 +1279,13 @@ def test_empty(self): | |||
a, b = histogram([], bins=([0, 1])) | |||
assert_array_equal(a, np.array([0])) | |||
assert_array_equal(b, np.array([0, 1])) | |||
|
|||
def test_error_binnum_type (self): | |||
#test should check the right error message is returned if a float is passed on a binnumber |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line length < 80 characters.
Looks like you merged master into your branch (bad idea) and got an extra commit. I think you can fix it by |
Where did you make this fix? I don't see a branch in your repo. |
Sorry for the mess! I did the rebase as you suggested, hope this is better. |
Apparently there is still a problem, but I could not find out why the test failed. Did I do something else wrong? I apologize again for the mess... |
It looks as though Travis CI failed to get a working Python 3.5 running for one of the tests. It's not really the code change that failed but rather Travis CI. (Or I'm misinterpretting the log output) |
Thanks @inesw . |
This pull request adds a test for issue #6469:
The issue itself has been fixed in 34b582a .
Checks that TypeError is raised if in function histogram argument bins is a float.
This pull request is part of a BCCN Berlin student project featuring @WHops @rahul-nt @MaxKirstein @inesw