MANT: refactor PyArrayMultiIterObject constructors #7441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates a single private implementation of the PyArrayMultiIterObject constructor, and calls it from the three existing public constructors.
|
☔ The latest upstream changes (presumably #8894) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Only saw this as it came up due to the "now unmergeable" message. It makes a lot of sense to me, but I'm not sure I'm the most competent reviewer... |
|
Yeah, looks pretty reasonable to me too - would be willing to look in more detail after a rebase |
|
Homu also reminded me that this existed, will try to find tine to rebase it in the next couple of weeks. |
|
@jaimefrio are you still working on this? |
|
I rebased this off master and opened #13445 to hopefully get this cleanup merged soon. I will tentatively close this one, but if @jaimefrio wishes to continue, feel free to close the other and reopen this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a single private implementation of the PyArrayMultiIterObject
constructor, and calls it from the three existing public constructors.