BUG: segfault inplace object reduceat, fixes #7465 #7466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| np.add.reduceat(arr, np.arange(4), out=arr, axis=-1) | ||
| assert_array_equal(arr, out) | ||
| arr = np.ones((2, 4), dtype=object) | ||
| arr[0, :] = [[2] for i in range(4)] |
There was a problem hiding this comment.
heh, should have realized it was tge same here. why the last two lines here? copy paste error?
There was a problem hiding this comment.
Oops, should be gone now.
jaimefrio
force-pushed
the
inplace_reduceat_segfault
branch
from
95d79f2
to
918c879
Compare
|
Thanks Jaime. I think my first mobile phone merge ;). |
jaimefrio
added a commit
to jaimefrio/numpy
that referenced
this pull request
Mar 27, 2016
This is a follow up to numpy#7407 and numpy#7466. It fixes an error in the comments (0 is the output and 1 is the input), moves them around so they apply to both branches of the if/else, and changes memcpy to memmove, since the memory segments can be overlapping, as pointed out by Valgrind in a really old issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.