BUG: Floating exception with invalid axis in np.lexsort #7529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an invalid axis was passed into PyArray_LexSort it would attempt to create a set of iterators to ignore that axis before checking to see if the axis was valid. This would cause a floating exception as the dimension of the invalid axis would on occasion return zero. This fixes that by moving the axis to before the iterator creation. Fixes numpy#7528
|
LGTM, thanks @simongibbons . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an invalid axis was passed into PyArray_LexSort it
would attempt to create a set of iterators to ignore that
axis before checking to see if the axis was valid. This
would cause a floating exception as the dimension of
the invalid axis would on occasion return zero.
This fixes that by moving the axis check to before the
iterator creation.
Fixes #7528