MAINT: Cleanup of random stuff #7539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,7 +6,22 @@ | |||
| import sys | |||
| import warnings | |||
|
|
|||
| from numpy.core import multiarray | |||
| from . import multiarray | |||
| from .multiarray import (CLIP, WRAP, RAISE, MAXDIMS, ALLOW_THREADS, | |||
There was a problem hiding this comment.
I think this would be better in the (numpy conventional) form
from .multiarray import (
CLIP, WRAP, RAISE, MAXDIMS, ALLOW_THREADS, etc
)
|
Could you please fix the formatting of the import? |
|
Yes. I just got a chance to look through your comments and I will include all of them. It might take me a day or two though. I had a second kid a couple of weeks ago and am just now starting to get back to work and online. |
madphysicist
force-pushed
the
random-cleanup
branch
from
caf011a
to
21d2fb7
Compare
|
Thanks @madphysicist . |
This was referenced May 6, 2016
|
No problem. What will happen to this PR if I continue to modify this branch and push the changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a series of things that I am cleaning up as I familiarize myself with how the C API is constructed at the lowest level. There are no significant code changes here, just some import cleanups, consistency imrovements, etc.
This PR is still a work in progress. Feel free to merge it, but I will be adding more stuff to this branch in the near future. I will remove this part of the message and squawk when I feel that the changes are complete.