-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Cleanup of random stuff #7539
Conversation
@@ -6,7 +6,22 @@ | |||
import sys | |||
import warnings | |||
|
|||
from numpy.core import multiarray | |||
from . import multiarray | |||
from .multiarray import (CLIP, WRAP, RAISE, MAXDIMS, ALLOW_THREADS, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would be better in the (numpy conventional) form
from .multiarray import (
CLIP, WRAP, RAISE, MAXDIMS, ALLOW_THREADS, etc
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might alphabetize also.
Could you please fix the formatting of the import? |
Yes. I just got a chance to look through your comments and I will include all of them. It might take me a day or two though. I had a second kid a couple of weeks ago and am just now starting to get back to work and online. |
caf011a
to
21d2fb7
Compare
Thanks @madphysicist . |
No problem. What will happen to this PR if I continue to modify this branch and push the changes? |
This is a series of things that I am cleaning up as I familiarize myself with how the C API is constructed at the lowest level. There are no significant code changes here, just some import cleanups, consistency imrovements, etc.
This PR is still a work in progress. Feel free to merge it, but I will be adding more stuff to this branch in the near future. I will remove this part of the message and squawk when I feel that the changes are complete.