MAINT: clean up testing.assert_raises_regexp, 2.6-specific code removed. #7636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The global also was ugly and not useful.
|
|
||
| return assert_raises_regex_impl(exception_class, expected_regexp, | ||
| callable_obj, *args, **kwargs) | ||
| if sys.version_info.major >= 3: |
There was a problem hiding this comment.
Why not do this up above at line 22
if sys.version_info[0] >= 3:
from io import StringIO
from nose.tools import assert_raises_regex
else:
from StringIO import StringIO
from nose.tools import assert_raises_regexp as assert_raises_regex
There was a problem hiding this comment.
nose is an optional dependency, so the import_nose call is hidden inside each test function on purpose. therefore can't do line 22.
also the line __tracebackhide__ = True # Hide traceback for py.test seems to be useful to people, so don't want to remove that
There was a problem hiding this comment.
Well, OK. Although one could question to what degree nose is optional ;)
There was a problem hiding this comment.
Many users will never run the tests, so making it non-optional will result in lots of errors on import numpy. all fixable of course, but why add the dependency?
|
Thanks Ralf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The global also was ugly and not useful.