MAINT: clearer exception message when importing multiarray fails. #7637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This regularly confuses users, see for example numpygh-5529. The path via which the multiarray import is reached has changed a few times in the last couple of years, but multiarray is always the first extension module to be imported, so this looks like a reasonable place to add the message.
| try: | ||
| from . import multiarray | ||
| except ImportError: | ||
| msg = """ |
There was a problem hiding this comment.
It might be usefull someday to have a format_message function that would remove prefixed spaces so we could make these messages look better. IIRC @pv had, or knew of, a function that did that.
There was a problem hiding this comment.
textwrap.dedent does that, I'm not aware of something fancier. but yes, may be useful especially for longer strings.
|
Thanks Ralf, and welcome back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regularly confuses users, see for example gh-5529.
The path via which the multiarray import is reached has changed a few times
in the last couple of years, but multiarray is always the first extension
module to be imported, so this looks like a reasonable place to add the
message.