f2py.compile issues (#7683)

[bertrand-l]

• DOC: add to f2py.compile's doctstring a description of the source_fn argument
• MAINT: avoid warnings about deprecated imp.load_module in distutil.misc_util with Python 3

That leaves one issue in #7683 that I have not yet figured out:

Could not locate executable C:ProgramsPython35python.exe
Executable C:ProgramsPython35python.exe does not exist

Looks like some string escaping issue, but nothing jumped at me looking at distutil.exec_command.{exec_command,find_executable} and I don't have a windows machine to test on.

[charris]

Could use a bit more explanation. I can't figure out what "dumped" means in this context ;) Should document the default, here and for the other optional arguments.

[bertrand-l]

I see your point :)

    source_fn : str, optional
        name of the file where the fortran source is written
        before being compiled. The default is to use a temporary
        file with an extension provided by the `extension` parameter

[charris]

Looks generally good. Could you also fix the other imp uses? there is one in numpy/_import_tools.py that could use the same fix as here, and another in numpy/testing/utils.py. Hmm, might make sense to put your import_module function in numpy/compat/py3k.py

[bertrand-l]

Good point. Will do and then update the PR. Thanks for the review!

[charris]

If you put it in py3k.py, npy_import_module might be a better name.

[bertrand-l]

@charris I think i've addressed all your comments (apart from the context manager in npy_import_module - keeping try: ... finally: ... block because imp.find_module returns a file object). Thanks again!

[charris]

Needs the heading

Parameters
-----------------

See doc/HOWTO_DOCUMENT.rst.txt or other functions for docstring.

[bertrand-l]

Done.

[charris]

Couple of style nits. Also, please squash the commits using numpy rebase -i HEAD~4. You can reorder the commits without problems (cut and paste) as long as they don't touch the same files, then squash them by replacing pick with s.

[bertrand-l]

All done, including the squashing. Also renamed compat.py3k.npy_import_module to compat.py3k.npy_load_module as it is closer to the name of the original python functions.

[bertrand-l]

oops, will fix that indentation, sorry [DONE]

[charris]

The new npy_load_module function needs .. versionadded:: 1.11.12 at the end of the summary, grep for examples. LGTM otherwise.

[bertrand-l]

ok thanks (and sorry there was yet one more thing i forgot). npy_load_module now has a versionadded.

[seberg]

Typo, I don't think we are 12 yet ;), seems to be 1.11.2

[bertrand-l]

@seberg, thanks. The versionadded is fixed now.

[charris]

Thanks @bertrand-l .

[charris]

For next time, note that your commit message summary line is too long. Lines should be kept <= 72 characters.

[bertrand-l]

Thanks @charris for the review and merge (and sorry it took so many iterations and comments)