-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add a tool for release authors and PRs. #8111
Conversation
e4666ce
to
7b34774
Compare
Such a script is useful, but I'm not inclined to put in my GitHub password for a script with a dependency I don't know about ...... It seems unnecessary to use a username/password here, all info is freely available (the scipy scripts don't need it either). |
It's probably a good idea to specify which of the several github API |
If you want to work around API rate limits, it's probably better to use
API tokens https://github.com/settings/tokens instead of user+password.
The API tokens can be fully read-only.
|
Agree about the password, but rate limiting was a problem as I don't read all the data down in a big blob but PR by PR. The 300+ needed PRs aren't tagged, Entering a hidden password interfered with output redirection. What I really wanted was ssh communication. @pv I'll take a look at tokens, I went with basic authentication to start. EDIT: The anonymous rate limit of 50/hour is pretty severe, I hit it on the first test. |
@charris I don't quite understand the advantage of retrieving PRs over using the commit history? |
7b34774
to
712d52f
Compare
@rgommers You get the PR title among other things. For an extended commit log, it would also be possible to retrieve the PR description. I also think it would good to improve release documentation in the long run and use it rather than the current release notes format. Our work is organized by PRs rather than commits so it makes sense to use them and the links provide a nice way for folks to get more detail on the PR. In any case, scipy has done the same for the last couple of releases. |
Updated to use a github token. I feel much better about that... |
@rgommers Also, note that it is possible to edit the PR titles and descriptions to improve or correct them, something that is hard to do with merged commits. |
Add the script tools/announce.py to generate the author and pull request lists needed in release announcements. Some bits of this are taken from the scipy gh_list.py and authors.py tools. Usage: $ ./tools/announce.py <github_user> <github_password> <revision_range> The output is utf8 rst. [ci skip]
712d52f
to
5291281
Compare
Putting this in as I will want to use it. |
Add the script tools/announce.py to generate the author and pull request
lists needed in release announcements. Some bits of this are taken from
the scipy gh_list.py and authors.py tools.
Usage:
$ ./tools/announce.py <github_user> <github_password> <revision_range>
The output is utf8 rst.
[ci skip]