-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Update .mailmap #8182
MAINT: Update .mailmap #8182
Conversation
478879c
to
682dc47
Compare
Let's not merge this just yet, there may be more modifications needed befor the 1.12 branch. |
@@ -18,7 +18,6 @@ Alex Griffing <argriffi@ncsu.edu> alex <argriffi@ncsu.edu> | |||
Alex Griffing <argriffi@ncsu.edu> argriffing <argriffi@ncsu.edu> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be removed too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact all entries of the form "A <B> A <B>" and "A <B> <B>" should probably be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? It associates a real name to the nickname.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry. I clicked on the wrong line. I am pretty sure I meant Alok Singhal <gandalf013@gmail.com> Alok Singhal <gandalf013@gmail.com>
which seems to add no new information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, looks like you are right. Entries of the form "A <B> <B>" are valid though, remaps possible nicknames based on address. Just found some decent .mailmap documentation at https://git-scm.com/docs/git-shortlog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like some others, also. I'm not going to worry about that now but do a cleanup sometime in the future.
Contributor nevimov did not want his full name used. [ci skip]
682dc47
to
29164fa
Compare
Contributor nevimov did not want his full name used.
[ci skip]