-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document actions controlled by standard properties #49
Comments
Is this still the case? As I see now, |
The user can create properties in various ways. A custom property attribute is only one of them. |
@CharliePoole How can I submit changes on wiki pages? |
@nunit/framework-team Can somebody else answer how you want people to do this nowadays? I know how I used to authorize people but I don't know the current practice. |
Hi @oriash93 - I'm afraid we don't really have a nice way to handle this at the moment 😞 Best thing to do is post your suggested changes in a comment or GitHub gist, and one of the team will copy them over. If it's a bigger change, you could also look at cloning the wiki repository itself, to get the original markdown - but unfortunately we don't currently have a set up to submit Pull Requests. Please don't think that our lack of infrastructure means contributions are any less welcome - it's something we want to get sorted! |
@ChrisMaddock Thanks for the quick reply. I will do so :) |
Out of curiosity, how do I clone the wiki? |
There is a description of how to clone a github wiki in this SO answer, but instead of So all in all not a very user-friendly experience, but if you just want to have the wiki locally and e.g. supply a diff then you just need to clone https://github.com/nunit/docs.wiki.git. |
@mikkelbu Thx, that worked like a charm! |
Hey all, I know it's been some years, but reviving this conversation here in case someone still wants to submit. We now have a docfx-based (and github pages hosted) site for our docs. On any doc, you can now click the link to "improve this doc" and submit a pull request. @oriash93, if you still want to take a crack at this, we'd love to have your contribution! If not, anyone else can feel free to raise their hand on it. Thanks! |
I'm afraid I don't have the time, but great news nevertheless! Good luck :) |
The PropertyAttribute page at https://github.com/nunit/docs/wiki/Property-Attribute says that properties of tests are not used by NUnit. That's not really true. Some standard properties like "Order" are used by NUnit. We should document that usage so users don't accidentally create properties that have an unexpected affect on how the test runs.
The text was updated successfully, but these errors were encountered: