Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProjectService is incorrectly initialized in agents #563

Closed
CharliePoole opened this issue Mar 5, 2019 · 0 comments
Closed

ProjectService is incorrectly initialized in agents #563

CharliePoole opened this issue Mar 5, 2019 · 0 comments

Comments

@CharliePoole
Copy link
Collaborator

I noticed this when examining all the services needed by an agent, hoping to build a version of the agent that doesn't depend on the engine itself.

In Program.cs we create and initialize the ProjectService for the engine. That service

  1. Is not intended to exist in the agent, because all projects are supposed to have been resolved before the agent is called and passed a TestPackage.

  2. Is never otherwise referenced in the engine.

While initializing it does no harm, it's confusing and makes it difficult to simplify the agent. There's also a risk that someone will start using it, perhaps re-expanding projects that are already expanded once.

@CharliePoole CharliePoole changed the title ProjectService is incorretly initialized in agents ProjectService is incorrectly initialized in agents Mar 7, 2019
@ChrisMaddock ChrisMaddock added this to the 3.10 milestone Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants