Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SetupFixture should have an AttributeUsage of Inherited = false #4158

Closed
stevenaw opened this issue Aug 19, 2022 · 2 comments
Closed

SetupFixture should have an AttributeUsage of Inherited = false #4158

stevenaw opened this issue Aug 19, 2022 · 2 comments
Assignees
@x789
Labels
closed:done good first issue help wanted is:bug
Milestone
4.0

Comments

@stevenaw
Copy link
Member

Based on the conversation in #3937, SetupFixture isn't intended to be used in a base class, however there is nothing stopping it from being added to a base class or even an abstract base class. One source of confusion here could be that the attribute is explicitly marked with Inherited = true prop in the AttributeUsage. It might help avoid confusion to make this explicitly false.
@x789
Copy link
Contributor

x789 commented Oct 1, 2022

I can take care of it.

Shall I also make this change in the v3 branch?
Normally, I would say that setting Inherited to false is a breaking change. But if I understood the discussion in #3937 correctly, the attribute does not work with derived classes, therefore it should be okay in this context.

x789 added a commit to x789/nunit that referenced this issue Oct 8, 2022
@x789
Add test for 'AttributeUsage.Inherited == false' (nunit#4158)
4bb32e8
x789 added a commit to x789/nunit that referenced this issue Oct 8, 2022
@x789
Mark attribute as 'non inheritable' (nunit#4158)
56e6018
x789 added a commit to x789/nunit that referenced this issue Oct 8, 2022
@x789
Add test for 'AttributeUsage.Inherited == false' (nunit#4158)
b17c9ee
x789 added a commit to x789/nunit that referenced this issue Oct 8, 2022
@x789
Mark attribute as 'non inheritable' (nunit#4158)
00ff1bb
This was referenced Oct 8, 2022
Merged
Merged
@stevenaw stevenaw added this to the 3.13.4 milestone Oct 12, 2022
@stevenaw
Copy link
Member Author

Thanks once again for tackling this!

lahma pushed a commit to lahma/nunit that referenced this issue Feb 26, 2023
@x789 @lahma
Add test for 'AttributeUsage.Inherited == false' (nunit#4158)
7fcc9f4
lahma pushed a commit to lahma/nunit that referenced this issue Feb 26, 2023
@x789 @lahma
Mark attribute as 'non inheritable' (nunit#4158)
e675685
@OsirisTerje OsirisTerje mentioned this issue Oct 29, 2023
Closed
@OsirisTerje OsirisTerje modified the milestones: 3.14, 4.0 Oct 29, 2023
@nicholashead nicholashead mentioned this issue Nov 22, 2023
Closed
stevenaw added a commit that referenced this issue Nov 23, 2023
@stevenaw
Revert "Mark attribute as 'non inheritable' (#4158)"
1351829 
This reverts commit 00ff1bb.
@stevenaw stevenaw mentioned this issue Nov 23, 2023
Merged
@OsirisTerje OsirisTerje mentioned this issue Nov 24, 2023
Closed
stevenaw added a commit that referenced this issue Nov 24, 2023
@stevenaw
Revert "Mark attribute as 'non inheritable' (#4158)"
5ca26bf 
This reverts commit 56e6018.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@x789 x789

Labels
closed:done good first issue help wanted is:bug
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
3 participants
@OsirisTerje @stevenaw @x789