Add support for the trans() helper return types #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why this if failing, let me know if I can fix it on my side. EDIT: The rights of the files look ok on my git |
|
all new files seem to be 0644 but not! https://travis-ci.org/nunomaduro/larastan/jobs/470623527#L458 See https://travis-ci.community/t/file-permissions-just-gone-up-to-664/1547 |
|
@szepeviktor Hey buddy, you are taking care of this right? |
|
@nunomaduro Yes. |
|
Solved in e1e8d6e @nunomaduro Is this PR ready to merge? |
|
Seems that tests are not passing ?
…On Fri 21 Dec 2018 at 21:39, Viktor Szépe ***@***.***> wrote:
Solved in e1e8d6e
<e1e8d6e>
@nunomaduro <https://github.com/nunomaduro> Is this PR ready to merge?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#220 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFNFVCIPwaMLDkAMhx78Ub56BzvpWwqbks5u7Ub9gaJpZM4ZckPa>
.
|
|
I've committed the fix to master so testing is only possible if you update this PR. |
|
I will rebase it.
…On Fri 21 Dec 2018 at 21:55, Viktor Szépe ***@***.***> wrote:
I've committed the fix to master so testing is only possible if you update
this PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#220 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFNFVH8L6vOxaWIv-yQ6XzASWibp3j4gks5u7UrcgaJpZM4ZckPa>
.
|
|
Perfect Pull Request, Thanks @Korri ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the return type of
trans()vstrans('key').I also added test for the other helper return type extensions