Macro implements MethodReflection instead of BuiltinMethodReflection

[ondrejmirtes]

This is fix for PHPStan 0.11.14. This PR changes what interface Macro implements, and some additonal cleanups stem from that.

This is closer to how PHPStan extensions should work. It's better to implement MethodReflection in a class directly rather than pass it through PhpMethodReflectionFactory.

I'm sorry about these BC breaks, it didn't occur to me that some extensions would be using the BuiltinMethodReflection interface. I want to have much clearer backwards compatibility boundary in the future, probably by tagging some classes and interfaces with @api. Everything else will be considered internal.

Right now, the rule of thumb is that backwards compatibility covers what's mentioned in the README.

[szepeviktor]

@nunomaduro What do you think? I think it's working.

[ondrejmirtes]

I'm also fixing #291 here.

[nunomaduro]

Blindly trusting you on this. 😅

[nunomaduro]

@ondrejmirtes Shouldn't we bump the required phpstan version?

[patrickbrouwers]

@nunomaduro I'm getting the following exceptions after updating:

 Whoops\Exception\ErrorException  : Uncaught InvalidArgumentException: Expected string, array of parts or Name instance in vendor/nikic/php-parser/lib/PhpParser/Node/Name.php:234
Stack trace:
#0 vendor/nikic/php-parser/lib/PhpParser/Node/Name.php(26): PhpParser\Node\Name::prepareName(Object(Closure))
#1 vendor/nunomaduro/larastan/src/Methods/Pipes/BuilderLocalMacros.php(61): PhpParser\Node\Name->__construct(Object(Closure))
#2 vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(163): NunoMaduro\Larastan\Methods\Pipes\BuilderLocalMacros->handle(Object(NunoMaduro\Larastan\Methods\Passable), Object(Closure))
#3 vendor/nunomaduro/larastan/src/Methods/Pipes/ModelScopes.php(67): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(NunoMaduro\Larastan\Methods\Passable))

  at vendor/nikic/php-parser/lib/PhpParser/Node/Name.php:234
    230|         } elseif ($name instanceof self) {
    231|             return $name->parts;
    232|         }
    233|
  > 234|         throw new \InvalidArgumentException(
    235|             'Expected string, array of parts or Name instance'
    236|         );
    237|     }
    238|

Seems to be caused by stuff like:

Route::bind('myModel', static function (string $uuid): MyModel {
    return MyModel::onlyTrashed()->where('uuid', $uuid)->firstOrFail();

    // no difference if used:
    return MyModel::query()->onlyTrashed()->where('uuid', $uuid)->firstOrFail();
});

[ondrejmirtes]

Not necessary to bump PHPStan version.

I'm gonna look into the exception, maybe I screwed up.

[ondrejmirtes]

I haven't realized that ReflectionFunction constructor also accepted closuures, not just strings.